Skip to content

Commit

Permalink
fix: request changes for #2
Browse files Browse the repository at this point in the history
Signed-off-by: ShikharBhatt <[email protected]>
  • Loading branch information
ShikharBhatt committed Sep 20, 2024
1 parent c70a602 commit ec00b2f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 30 deletions.
13 changes: 2 additions & 11 deletions apps/vc-api/src/vc-api/credentials/credentials.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*/
import { BadRequestException, Injectable, InternalServerErrorException } from '@nestjs/common';
import { DIDService } from '../../did/did.service';
import { KeyService } from '../../key/key.service';
import { IssueCredentialDto } from './dtos/issue-credential.dto';
import { VerifiableCredentialDto } from './dtos/verifiable-credential.dto';
import { VerifiablePresentationDto } from './dtos/verifiable-presentation.dto';
Expand Down Expand Up @@ -61,9 +60,8 @@ export class CredentialsService implements CredentialVerifier {
const w3cVerifyCredentialOptions: W3cVerifyCredentialOptions<ClaimFormat.LdpVc> = {
credential: W3cJsonLdVerifiableCredential.fromJson(vc)
};
const obj = { ...w3cVerifyCredentialOptions };
const verifyCredential: W3cVerifyCredentialResult =
await this.credoService.agent.w3cCredentials.verifyCredential(obj as any);
await this.credoService.agent.w3cCredentials.verifyCredential(w3cVerifyCredentialOptions as any);
return transformVerificationResult(verifyCredential);
}

Expand All @@ -85,13 +83,6 @@ export class CredentialsService implements CredentialVerifier {
}
const presentation = pex.presentationFrom(presentationDefinition, verifiableCredential);

const submissionContextUri = 'https://identity.foundation/presentation-exchange/submission/v1';

presentation['@context'] = Array.isArray(presentation['@context'])
? presentation['@context']
: [presentation['@context']];

presentation['@context'] = presentation['@context'].filter((c) => c !== submissionContextUri);
return presentation as PresentationDto;
}

Expand Down Expand Up @@ -127,7 +118,7 @@ export class CredentialsService implements CredentialVerifier {
const signPresentationDto: ProvePresentationDto = {
presentation: {
'@context': ['https://www.w3.org/2018/credentials/v1'],
type: ['VerifiablePresentation', 'DidAuth'],
type: ['VerifiablePresentation'],
holder: authenticateDto.did
},
options: authenticateDto.options
Expand Down
17 changes: 0 additions & 17 deletions apps/vc-api/src/vc-api/credentials/dtos/create-presentation.dto.ts

This file was deleted.

3 changes: 1 addition & 2 deletions apps/vc-api/test/vc-api/credential.service.spec.data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -356,8 +356,7 @@ export const didAuth = {
'https://www.w3.org/2018/credentials/v1'
],
type: [
'VerifiablePresentation',
'DidAuth'
'VerifiablePresentation'
],
holder: 'did:key:z6MkoB84PJkXzFpbqtfYV5WqBKHCSDf7A1SeepwzvE36QvCF',
proof: {
Expand Down

0 comments on commit ec00b2f

Please sign in to comment.