feat(react-hooks): extend credential providers with format data #146
Conversation
Signed-off-by: Akiff Manji <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #146 +/- ##
=======================================
Coverage 87.07% 87.07%
=======================================
Files 45 45
Lines 681 681
Branches 84 84
=======================================
Hits 593 593
Misses 88 88 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
|
||
| export const useCredentials = () => { | ||
| export const useCombinedCredentials = () => { |
There was a problem hiding this comment.
Maybe useCredentialsWithFormatData()? Or do you think that is too long?
combined doesn't really give any context on what is combined
TimoGlastra
changed the title
|
|
||
| interface CombinedRecord<R extends BaseRecord> { | ||
| record: R | ||
| formatData: GetFormatDataReturn<[IndyCredentialFormat]> |
There was a problem hiding this comment.
If we want to only specifically do IndyCredentialFormat I think we should name it accordingly.
I also implemented this locally for some projects and just made the formatData a separate hook.
const formattedCredential = useCredentialFormatDataById(credentialId)
or
const formattedCredential = useCredentialFormatData()
Which could then optionally take a generic for the format data, i.e. IndyCredentialFormat. I could also create a PR with this code (and for proofs.)
|
I think this PR is probably quite out of sync with what's in AFJ today. IMHO if you have working code that expands on this and it's not adding unnecessary work for you I'd say maybe we go with that instead. Let me know. I'd be happy to review once it's ready. |
|
Opened #231 that supersedes this. |
Signed-off-by: Akiff Manji [email protected]