Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: openid4vc #260

Merged
merged 8 commits into from
Mar 30, 2024
Merged

Conversation

TimoGlastra
Copy link
Contributor

This PR adds support for openid4vc issuance and verification with SD-JWT credentials in the REST wrapper.

It also does some cleanup, allows to configure cheqd legders, and updates the programmatic API (if you're not using the docker image / cli). Also added some extra samples using the cli, config file or programmatic use

I'm currently working on some docs to add to the Credo Docs website, but I don't think it should hold up this PR and the release.

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 66.72598% with 187 lines in your changes are missing coverage. Please review.

Project coverage is 57.91%. Comparing base (3849aec) to head (2c60688).

Files Patch % Lines
...rs/openid4vc/issuers/OpenId4VcIssuersController.ts 46.55% 31 Missing ⚠️
...essions/OpenId4VcVerificationSessionsController.ts 60.27% 28 Missing and 1 partial ⚠️
packages/rest/src/setup/setupApp.ts 68.29% 19 Missing and 7 partials ⚠️
...ce-sessions/OpenId4VcIssuanceSessionsController.ts 60.31% 25 Missing ⚠️
...penid4vc/verifiers/OpenId4VcVerifiersController.ts 51.06% 23 Missing ⚠️
.../rest/src/controllers/tenants/TenantsController.ts 50.00% 16 Missing ⚠️
packages/rest/src/utils/agent.ts 65.38% 9 Missing ⚠️
...src/controllers/didcomm/proofs/ProofsController.ts 70.58% 4 Missing and 1 partial ⚠️
packages/rest/src/events/emitEvent.ts 73.68% 4 Missing and 1 partial ⚠️
...llers/didcomm/credentials/CredentialsController.ts 66.66% 3 Missing and 1 partial ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
- Coverage   62.28%   57.91%   -4.37%     
==========================================
  Files          79       94      +15     
  Lines        1832     2526     +694     
  Branches      375      512     +137     
==========================================
+ Hits         1141     1463     +322     
- Misses        635      983     +348     
- Partials       56       80      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Timo Glastra <[email protected]>
- 💻 **CLI** that makes it super easy to start an instance of the REST API.
- 🌐 **Interoperable** with all major Aries implementations.
- 🧑 **Multi-tenant** Use the same agent and server for as many tenants as you want. Each tenants has it's own separate encrypted storage.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: tenant (singular) and its

;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah that's sloppy of me, thanks :) 🙌

@TimoGlastra TimoGlastra merged commit e3e4026 into openwallet-foundation:main Mar 30, 2024
9 of 10 checks passed
@TimoGlastra TimoGlastra deleted the feat/openid4vc branch March 30, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants