Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest): auth improvements #263

Merged
merged 2 commits into from
Mar 31, 2024

Conversation

TimoGlastra
Copy link
Contributor

Refactors the auth implementation so that it is handled as auth internally (easiest with TSOA), but isn't advertised as auth, every request now has a x-tenant-id header param that you can provide

image

If incorrect x-tenant-id value was provided you will get a bad request error.

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.95%. Comparing base (d09b153) to head (73632e4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
+ Coverage   57.91%   57.95%   +0.03%     
==========================================
  Files          94       95       +1     
  Lines        2526     2528       +2     
  Branches      512      513       +1     
==========================================
+ Hits         1463     1465       +2     
  Misses        983      983              
  Partials       80       80              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimoGlastra TimoGlastra merged commit 791d6ee into openwallet-foundation:main Mar 31, 2024
9 checks passed
@TimoGlastra TimoGlastra deleted the auth-improvements branch March 31, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant