Skip to content
This repository was archived by the owner on Jan 24, 2025. It is now read-only.

Conversation

@mcovarr
Copy link
Contributor

@mcovarr mcovarr commented Feb 19, 2020

No description provided.

Copy link
Member

@patmagee patmagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and catches the vast majority of casses I can think of. The only thing we might consider adding is an expresson or two containing a call to an engne function

echo ~{-42}
echo ~{+42}
echo ~{i}
echo ~{+i} # fails in Cromwell 48
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably keep these kinds of comments in a Cromwell issue tracker rather than the openWDL spec repo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants