Skip to content
This repository was archived by the owner on Dec 20, 2023. It is now read-only.

add lcov report #372

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add lcov report #372

wants to merge 1 commit into from

Conversation

jenniexie
Copy link
Contributor

@jenniexie jenniexie commented Sep 18, 2019 •
edited
Loading

added code coverage using lcov for github openweave
This is for :#323

@gerickson
Copy link
Contributor

While this isn't harmful, given that we have codecov.io integration for openweave-core, is there value for this addition?

@jenniexie
Copy link
Contributor Author

While this isn't harmful, given that we have codecov.io integration for openweave-core, is there value for this addition?
Hi Grant:
By looking at our internal lcov report in Jenkins job, it has line, function and branch coverage, vs github codecov.io only has line coverage.
Since it has more coverage data, should we have the data for openweave-core on github?

@jenniexie jenniexie force-pushed the jexie/add_lcov branch 4 times, most recently from a37a221 to 73332fd Compare September 19, 2019 22:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

1 more reviewer

@gerickson gerickson gerickson approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jenniexie @gerickson