Skip to content
This repository was archived by the owner on Dec 20, 2023. It is now read-only.

Add fileName and lineNumber in WeaveLog* #640

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add fileName and lineNumber in WeaveLog* #640

wants to merge 1 commit into from

Conversation

didishe90
Copy link
Contributor

Help debug and identify spammy log

gerickson
gerickson suggested changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@gerickson gerickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be conditionalized by a compile-time configuration flag and should be disabled by default. File names, in particular, will lead to an explosion in debug image code size.

@didishe90
Add fileName and lineNumber in WeaveLog*
3675ef2 
Help debug and identify spammy log
@didishe90 didishe90 requested a review from gerickson January 19, 2021 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gerickson gerickson Awaiting requested review from gerickson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@didishe90 @gerickson