-
-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start a SVSU collection in Contrib #831
base: main
Are you sure you want to change the base?
Conversation
This first commit adds all our current College Algebra problems.
When reviewing the problems, I realize now that while most of the problems were written at SVSU, there are few problems that are modifications of existing problems from the OPL. The edits are mostly in terminology and notation, which is why we chose to fork the problems and create a local version rather than modifying the existing problems. I do not know what is the proper way of handling this, but I will at least add some explanations to the modified files. |
Would you be able to identify which problems are modifications, and perhaps also which problems they came from? |
For now I removed all problems that were modifications of existing problems from the OPL. I will go through those one by one and see if some of them can be submitted as changes to the existing problems instead. All the remaining problems after the last commit were written here at SVSU. |
This problem was originally removed since it was a modification of a problem from the OPL, but it is now completely re-written and has almost nothing in common with the original problem.
This is the problem Mizzou/Algebra/graph_polynomials/find_all_info_01.pg from the OPL, rewritten to use PGML and scaffold. Hints and solutions were also added.
Thanks @lahvak, for separating out those problems. The way that modifications to existing problems have been handled to this point is through the If
Ultimately, a 'modified' problem should have either
|
Thank you, this is really useful. Is there any policy on generating the unique MLT tags? |
Unfortunately, no, not really. I'm working on some tools to help address this though. However, in the meantime, if you have command-line access, the following command can help confirm whether or not you do have a unique MLT name:
For example, if you perform the above action for MLT group names should not include any spaces, use underscore or hyphen or CamelCase to deal with multiple words. |
For future reference, I have added these instructions to the Submitting problems to the OPL page of the WeBWorK wiki. |
Sorry, I keep asking questions. I am now looking at another problem from our collection, and it is a problem from the OPL rewritten using PGML, with added hints and a solution, but with no modification to the actual wording of the problem. Would it be better to submit it as a new problem with the MLT tags, or to create a separate pull request changing the old problem in the OPL? |
It's really no problem. If an update doesn't change the main text or logic of the problem, it should be pushed as a replacement for the existing OPL problem rather than as an MLT modification. I view the addition of hints/solutions in the same way as bug fixes -- there's no benefit to keeping the 'old' version. (GitHub keeps track of changes, so the original is never actually 'lost'...) |
This is a modification of an existing OPL problem /UMN/algebraKaufmannSchwitters/ks_9_4_prob07.pg The changes are as follows: * Rewrite in PGML, add solutions and hints * Choose $b randomly so it is not always 1 * Change the notation from a,b,c to x_1, x_2, x_3 * Add a leading coefficient * Randomly flip the polynomial horizontally and/or vertically for more variability * Scale the polynomial to better fit the window Submitting as a new problem rather than a fix of old problem mainly because of the change in notation, but also in case new bugs are introduced.
This first commit adds all our current College Algebra problems.
They are hopefully correctly tagged. We would be delighted if any of these eventually ended up in the OPL.