Add withData hoc for data fetching #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ything needing data from external datasource. Fix missin alt on image tag warning. fix missing alt on image warning Fix loading issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing alt prop on img tag warning.
Add withData higher order component for fetching data and injecting response as props. It just takes a url right now so any component that needs to fetch data can just be wrapped in it and passed a url and it will receive
data,error, andisLoadingprops to work with.This is also pretty much how react-apollo works, which you can use to fetch data from the github graphql api, so this could be a good way to help transition to that if anyone wants to try that out.