Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Added support for more WPA EAP client parameters #313 #318

Merged
merged 4 commits into from
Nov 7, 2024
Merged

[feature] Added support for more WPA EAP client parameters #313 #318

merged 4 commits into from
Nov 7, 2024

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented Sep 20, 2024

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

Closes #313

@coveralls
Copy link

coveralls commented Sep 20, 2024 •
edited
Loading

Coverage Status

coverage: 99.191%. remained the same
when pulling a7c922f on issues/297-wiregaurd-docs
into 3617699 on master.

nemesifier
nemesifier requested changes Sep 25, 2024
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs are missing here.

@pandafy
Copy link
Member Author

pandafy commented Sep 27, 2024

I don't see a table explaining the WPA client parameters
Shall I add the options here in the example?

https://netjsonconfig.openwisp.org/en/latest/backends/openwrt.html#wpa2-enterprise-802-1x-client

@nemesifier
Copy link
Member

I don't see a table explaining the WPA client parameters Shall I add the options here in the example?

https://netjsonconfig.openwisp.org/en/latest/backends/openwrt.html#wpa2-enterprise-802-1x-client

Yes please.

@nemesifier nemesifier merged commit c1d7f6a into master Nov 7, 2024
8 checks passed
@nemesifier nemesifier deleted the issues/297-wiregaurd-docs branch November 7, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Support more WPA EAP client parameters
3 participants
@pandafy @coveralls @nemesifier