[geo] Restrict to points only #151 #175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nemesisdesign Please can review this? |
Fixed the issue by adding a clean method to the location model. This method ensures that when the geometry is not None, it should be an instance of a Point Geometry else a ValidationError is raised Fixes #151
1 similar comment
nemesifier
requested changes
Jul 1, 2020
There was a problem hiding this comment.
It looks good, the reason I left this open was that I thought we should prevent the user from entering other type of geometries in the admin. Maybe we can do that by overriding the widget in a way that forces it to use the widget for point, look for geom_type here: https://github.com/makinacorpus/django-leaflet/blob/master/leaflet/forms/widgets.py
Do you think you can do that?
|
😄 I can have a look at it |
nemesifier
requested changes
Jul 6, 2020
nemesifier
force-pushed
the
master
branch
2 times, most recently
from
0a1c550 to
bbe0dab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue by adding a clean method
to the location model. This method
ensures that when the geometry is not
None, it should be an instance of a Point
Geometry else a ValidationError is raised
Fixed #151