[fix:ui] Fixed UI switcher in VPN server admin #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
force-pushed
the
fix-vpn-switcher
branch
2 times, most recently
from
e9789dd to
25f2050
Compare
Base test classes were quite messed up. With this change, redundancy is reduced and it should be easier to read the base test methods.
Due to changes in the Django admin HTML, the form rows weren't hidden as expected. This patch should fix the issue and also be more robust to future Django upgrades. Added a selenium test.
nemesifier
force-pushed
the
fix-vpn-switcher
branch
from
25f2050 to
c3f2d7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes in the Django admin HTML, the form rows weren't hidden as expected.
This patch should fix the issue and also be more robust to future Django upgrades.
Added a selenium test.