[fix] Always convert MAC address to uppercase format #922 #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandafy
force-pushed
the
issues/922-mac-address-uppercase
branch
from
8cb8f40 to
7adce69
Compare
pandafy
requested changes
Dec 23, 2024
Resolved linting issue: E202 whitespace before '}' in ./openwisp_controller/geo/tests/test_api.py at line 97. Ensured code adheres to PEP 8 standards for better readability and consistency.
dee077
force-pushed
the
issues/922-mac-address-uppercase
branch
from
7adce69 to
1b4d7bc
Compare
…penwisp#922 Automatically convert the MAC address to uppercase format in the model clean method to ensure consistency with the openwisp-config agent behavior. Fixes openwisp#922
dee077
force-pushed
the
issues/922-mac-address-uppercase
branch
from
1b4d7bc to
1309586
Compare
nemesifier
requested changes
Dec 23, 2024
There was a problem hiding this comment.
@dee077 great progress, thanks for following up! 🙏
I'll apply a small change and verify the test fails without the fix, if good I will merge.
nemesifier
reviewed
Dec 23, 2024
nemesifier
approved these changes
Dec 23, 2024
nemesifier
changed the title
nemesifier
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically convert the MAC address to uppercase format in the model clean method to ensure consistency with the openwisp-config agent behavior.
Fixed lint error in ./openwisp_controller/geo/tests/test_api.py:97:52: E202 whitespace before '}'.
Fixes #922
Checklist
Reference to Existing Issue
Closes #922.
Description of Changes
MAC addressto uppercase format in themodel cleanmethod for consistency../openwisp_controller/geo/tests/test_api.py:97:52: E202 whitespace before '}'.Screenshot