Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Implement Iperf3 check #385 #394

Merged
merged 64 commits into from
Aug 9, 2022
Merged

[feature] Implement Iperf3 check #385 #394

merged 64 commits into from
Aug 9, 2022

Commits on Aug 9, 2022

  1. [feature] Implement Iperf check #385 

    - Added initial code for Iperf check class.
- Added tests.

Closes #385
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    506f044 View commit details
    Browse the repository at this point in the history

  2. [feature] Added device connection logic

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    6bd112b View commit details
    Browse the repository at this point in the history

  3. [feature] Added charts and metric (TCP)

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    c47467e View commit details
    Browse the repository at this point in the history

  4. [feauture] UDP mode added

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    488990b View commit details
    Browse the repository at this point in the history

  5. [chores] Removed unnecessary code

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    f890ba9 View commit details
    Browse the repository at this point in the history

  6. [refactor] Refactor device connection logic 

    - Refactor device connection logic, removed try-except.
- Removed redundant line from test_selenium.py.
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    a6ec0dc View commit details
    Browse the repository at this point in the history

  7. [chores] Move Iperf server settings to project settings

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    f3a79a5 View commit details
    Browse the repository at this point in the history

  8. [chores] Remove redundant else in guard clause

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    69f63fc View commit details
    Browse the repository at this point in the history

  9. [fix] Fixed iperf check execution if device connection not working #399 

    - We need to check device_connection is_working just right after connect().
- because it may be possible that authentication (publickey) failed.
- or any other failure happened during connect().

Fixes #399
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    9a346ef View commit details
    Browse the repository at this point in the history

  10. [chores] Minor changes in configuration 

    - Removed redundant test code.
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    9383f3a View commit details
    Browse the repository at this point in the history

  11. [requested-changes] Changed chart conf and added log warnings 

    - Changed transfer chart configuration
- Added more descriptive log warnings.
- Logged non-zero exit code warnings.
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    bf7dfd5 View commit details
    Browse the repository at this point in the history

  12. [change] Handled iperf in each mode

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    9d98a66 View commit details
    Browse the repository at this point in the history

  13. [refactor] Iperf check class #405 

    Closes #405
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    3050edf View commit details
    Browse the repository at this point in the history

  14. [tests] Added tests for iperf check

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    efdc70a View commit details
    Browse the repository at this point in the history

  15. [docs] Added Iperf check instructions

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    0f65c6a View commit details
    Browse the repository at this point in the history

  16. [requested-changes] Added bandwidth and transfer charts (UDP)

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    7396e79 View commit details
    Browse the repository at this point in the history

  17. [docs] Added transfer & bandwidth charts (UDP) instructions

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    2b881e0 View commit details
    Browse the repository at this point in the history

  18. [requested-changes] Logger warning changed

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    4d732bb View commit details
    Browse the repository at this point in the history

  19. [tests] Added test for Iperf check

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    8c488ab View commit details
    Browse the repository at this point in the history

  20. [requested-changes] Set AUTO_IPERF to false

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    f895630 View commit details
    Browse the repository at this point in the history

  21. [docs] Updated iperf table structure & minor changes

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    c75428e View commit details
    Browse the repository at this point in the history

  22. [tests] Improved Iperf tests

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    72a9eef View commit details
    Browse the repository at this point in the history

  23. [change] Made Iperf check command configurable #398 

    - Made Iperf check command configurable
- Added some more tests and improved previous ones.

Closes #398
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    5908994 View commit details
    Browse the repository at this point in the history

  24. [docs] Added OPENWISP_MONITORING_IPERF_CHECK_CONFIG 

    - Added Iperf configurable command in docs.
- Minor changes in tests.
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    ec80f2f View commit details
    Browse the repository at this point in the history

  25. [fix] Fixed JSONDecodeError if iperf3 is not installed #412 

    Fixes #412
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    50921cb View commit details
    Browse the repository at this point in the history

  26. [requested-changes] Docs improvement

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    56543bf View commit details
    Browse the repository at this point in the history

  27. [change] Configured celery beat for Iperf check

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    ef433ea View commit details
    Browse the repository at this point in the history

  28. [docs] Added Iperf check celery beat configuration #390 

    Closes #390
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    38991a9 View commit details
    Browse the repository at this point in the history

  29. [change] Configured celery beat for Iperf check in settings #390 

    Closes #390
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    64b607d View commit details
    Browse the repository at this point in the history

  30. [docs] Added iperf celery beat configuration 

    - Added iperf celery beat configuration.
- Reverted previous docs changes.
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    ce23bd0 View commit details
    Browse the repository at this point in the history

  31. [requested-changes] Moved iperf celery beat settings

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    93f9220 View commit details
    Browse the repository at this point in the history

  32. [change] Removed manual conversion 

    - Removed manual conversion of iperf test result.
- Improved tests.
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    8400291 View commit details
    Browse the repository at this point in the history

  33. [docs] Minor changes

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    f2b3110 View commit details
    Browse the repository at this point in the history

  34. [requested-changes] Removed CHECK_LIST from run_checks args 

    - Updated docs.
- Moved iperf test constants.
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    91d472a View commit details
    Browse the repository at this point in the history

  35. [feature] Added initial alert settings for iperf check 

    - Added alert settings for iperf check on the iperf_result field
just for testing purpose.
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    a2abe5d View commit details
    Browse the repository at this point in the history

  36. [tests] Added test_iperf_check_alert_notification

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    391537e View commit details
    Browse the repository at this point in the history

  37. [feature] Added alert for related_field (Iperf jitter) #406 

    Closes #406
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    9810d24 View commit details
    Browse the repository at this point in the history

  38. [changes] Improved alert_on_related field

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    d219e9f View commit details
    Browse the repository at this point in the history

  39. [tests] Added tests for alert_on_related_field

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    8082881 View commit details
    Browse the repository at this point in the history

  40. [docs] Added alert_on_related_field

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    e4d6061 View commit details
    Browse the repository at this point in the history

  41. [requested-changes] Remove is_working filter, formatted test json 

    - Remove is_working filter from getdeviceconneciton method.
- Formatted iperf test json.
- Added line breaks in docs.
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    df31203 View commit details
    Browse the repository at this point in the history

  42. [requested-changes] Explicitly specify ping & config checks 

    - Added ping config checks in celery beat configuration.
- If args is None executes all checks.
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    02100af View commit details
    Browse the repository at this point in the history

  43. [docs] Moved images to docs/1.1

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    27732e6 View commit details
    Browse the repository at this point in the history

  44. [feature] Added support for iperf3 auth #414 

    - Added username, password, rsa-public-key-path parameter
to DEFAULT_IPERF_CHECK_CONFIG.

Closes #414
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    8a9b826 View commit details
    Browse the repository at this point in the history

  45. [tests] Added tests for iperf auth

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    fb1bc26 View commit details
    Browse the repository at this point in the history

  46. [requested-changes] Changed iperf auth logic & improved tests 

    - Changed iperf auth logic (RSA key in params instead of path).
- Added IPERF_CHECK_RSA_KEY_DELETE (If true RSA will be delete from the device).
- Added IPERF_CHECK_RSA_KEY_PATH (To set default iperf RSA public key).
- Impoved existing tests as per review suggestion.
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    87ddce9 View commit details
    Browse the repository at this point in the history

  47. [docs] Added iperf auth

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    fa74e99 View commit details
    Browse the repository at this point in the history

  48. [change] Changed chart types for iperf check #417 

    - Connected data points with new bar+lines chart type.
- Added fill(0) to the chart query to fill blank data points(ie.N/A).

Closes #417
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    1d71d7c View commit details
    Browse the repository at this point in the history

  49. [change] Changed chart look according to feedback

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    50256d2 View commit details
    Browse the repository at this point in the history

  50. [change] Combined all iperf settings into one setting #418 

    - Combined all iperf settings into one setting.
- Removed default from OPENWISP_MONITORING_IPERF_CHECK_CONFIG
- The order of getting params for iperf check is:
check_params(through admin panel)-> OPENWISP_MONITORING_IPERF_CHECK_CONFIG-> DEFAULT_IPERF_CHECK_CONFIG
- Updated iperf tests.

Closes #418
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    01cd70e View commit details
    Browse the repository at this point in the history

  51. [feature] Added --bitrate param to iperf check 

    - Added bitrate param to tcp and udp mode.
- Improved iperf tests.
- Improved alert_on_related_field tests.
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    c7b6cb1 View commit details
    Browse the repository at this point in the history

  52. [change] Added validation for settings config and non json error hand… 

    …ling
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    46d86f0 View commit details
    Browse the repository at this point in the history

  53. [change] Added connect_points to iperf charts

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    f9a4f98 View commit details
    Browse the repository at this point in the history

  54. [change] Docs & iperf charts improved

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    1e4196b View commit details
    Browse the repository at this point in the history

  55. [feature] Added adaptive_prefix to monitoring charts

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    c4ce4a0 View commit details
    Browse the repository at this point in the history

  56. [requested-changes] Docs and minor changes

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    719932e View commit details
    Browse the repository at this point in the history

  57. [fix] Fixed iperf bar charts x-axis incosistency #422 

    - Found that options.mode = 'lines+markers' for the
stackedbar+lines charts which streches charts x-axis
to some backward time we can use options.mode = 'lines'
for iperf charts to avoid this.

Fixes #422
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    631d2bf View commit details
    Browse the repository at this point in the history

  58. [requested-changes] Fixed chart.js linting

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    3524a68 View commit details
    Browse the repository at this point in the history

  59. [requested-changes] Combine iperf charts & improved docs 

    - Combined transfer and bandwidth charts.
- improved docs.
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    abe40f8 View commit details
    Browse the repository at this point in the history

  60. [requested-changes] Moved rsa_public_key_path to OPENWISP_IPERF_CHECK… 

    …_CONFIG
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    b12d9b5 View commit details
    Browse the repository at this point in the history

  61. [requested-changes] Removed alert_on_related field 

    - Removed alert_on_related feature from this PR.
    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    e0e23d9 View commit details
    Browse the repository at this point in the history

  62. [requested-changes] Removed rsa_public_key_path from settings

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    13b6416 View commit details
    Browse the repository at this point in the history

  63. [docs] Improved README

    @nemesifier @Aryamanz29
    nemesifier authored and Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    1b1dd84 View commit details
    Browse the repository at this point in the history

  64. [requested-changes] Added iperf to available features

    @Aryamanz29
    Aryamanz29 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    9213aaf View commit details
    Browse the repository at this point in the history