[deps] Upgraded selenium

Upgraded the selenium dependency to match the recent upgrade in openwisp-controller at commit openwisp/openwisp-controller@b05c875.
openwisp · May 13, 2023 · 012b27b · 012b27b
1 parent de20571
commit 012b27b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 15 deletions.
diff --git a/openwisp_network_topology/tests/test_selenium.py b/openwisp_network_topology/tests/test_selenium.py
@@ -107,21 +107,15 @@ def _assert_topology_graph(self):
         WebDriverWait(self.web_driver, 2).until(
             EC.visibility_of_element_located((By.CLASS_NAME, 'njg-aboutContainer'))
         )
-        topology_graph_label_keys = self.web_driver.find_elements_by_css_selector(
-            '.njg-keyLabel'
-        )
-        topology_graph_label_values = self.web_driver.find_elements_by_css_selector(
-            '.njg-valueLabel'
-        )
         console_logs = self.web_driver.get_log('browser')
         console_errors = self._get_console_errors(console_logs)
         self.assertEqual(console_errors, [])
         topology_graph_dict = self.topology.json(dict=True)
-        topology_graph_label_keys = self.web_driver.find_elements_by_css_selector(
-            '.njg-keyLabel'
+        topology_graph_label_keys = self.web_driver.find_elements(
+            By.CSS_SELECTOR, '.njg-keyLabel'
         )
-        topology_graph_label_values = self.web_driver.find_elements_by_css_selector(
-            '.njg-valueLabel'
+        topology_graph_label_values = self.web_driver.find_elements(
+            By.CSS_SELECTOR, '.njg-valueLabel'
         )
         self.assertEqual(len(topology_graph_label_keys), len(self._EXPECTED_KEYS))
         # ensure correct topology graph labels are present
@@ -144,15 +138,15 @@ def test_topology_admin_view_graph_visualizer(self):
         path = reverse(f'{self.prefix}_topology_change', args=[self.topology.pk])
         self.login(username=self.admin_username, password=self.admin_password)
         self.open(path)
-        self.web_driver.find_element_by_css_selector('input.visualizelink').click()
+        self.web_driver.find_element(By.CSS_SELECTOR, 'input.visualizelink').click()
         self._assert_topology_graph()
 
     def test_topology_non_admin_view_graph_visualizer(self):
         path = reverse('topology_list')
         self.login(username=self.admin_username, password=self.admin_password)
         self.open(path)
-        topology_graph_element = self.web_driver.find_element_by_xpath(
-            "//ul[@id='menu']/li/a"
+        topology_graph_element = self.web_driver.find_element(
+            By.XPATH, "//ul[@id='menu']/li/a"
         )
         topology_graph_element.click()
         self._assert_topology_graph()
diff --git a/requirements-test.txt b/requirements-test.txt
@@ -2,8 +2,7 @@ responses~=0.16.0
 pytest-asyncio~=0.14.0
 pytest-django~=4.5.2
 freezegun~=1.1.0
-selenium~=3.141.0
-urllib3~=1.26.1
+selenium~=4.9.0
 # Needed to test integrations
 openwisp-monitoring @ https://github.com/openwisp/openwisp-monitoring/tarball/master
 openwisp-controller @ https://github.com/openwisp/openwisp-controller/tarball/master