Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Fixed non-admin view visualizer disappears on resizing the window #193 #197

Merged
merged 1 commit into from
Jun 7, 2023
Merged

[fix] Fixed non-admin view visualizer disappears on resizing the window #193 #197

merged 1 commit into from
Jun 7, 2023

Conversation

Aryamanz29
Copy link
Member

Fixes #193

@Aryamanz29 Aryamanz29 self-assigned this May 28, 2023
@Aryamanz29 Aryamanz29 force-pushed the issue-193/fix-admin-visualizer-on-window-resizing branch 7 times, most recently from 13bb842 to f02132e Compare May 28, 2023 12:51
@coveralls
Copy link

coveralls commented May 28, 2023 •
edited
Loading

Coverage Status

coverage: 99.328%. remained the same when pulling 82f051d on issue-193/fix-admin-visualizer-on-window-resizing into c023136 on master.

@Aryamanz29 Aryamanz29 marked this pull request as ready for review May 28, 2023 12:57
@Aryamanz29 Aryamanz29 force-pushed the issue-193/fix-admin-visualizer-on-window-resizing branch from f02132e to c503269 Compare June 7, 2023 09:21
nemesifier
nemesifier approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

nemesifier
nemesifier requested changes Jun 7, 2023
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a conflict to resolve after merging other PRs.

@Aryamanz29 Aryamanz29 force-pushed the issue-193/fix-admin-visualizer-on-window-resizing branch 2 times, most recently from c503269 to e81b28c Compare June 7, 2023 18:06
@nemesifier nemesifier merged commit 82c9118 into master Jun 7, 2023
14 checks passed
@nemesifier nemesifier deleted the issue-193/fix-admin-visualizer-on-window-resizing branch June 7, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier approved these changes

Assignees

@Aryamanz29 Aryamanz29

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Visualizer disappears on resizing window for published topology
3 participants
@Aryamanz29 @coveralls @nemesifier