[fix] Fixed changing status of link from LinkAdmin #154 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
requested changes
Jun 6, 2023
| @@ -84,6 +84,7 @@ def link_get_queryset(cls, qs): | |||
| 'organization__name', | |||
| 'organization__is_active', | |||
| 'status', | |||
| 'properties', | |||
There was a problem hiding this comment.
do we need to add user_properties too here?
I would do the same on node_get_queryset for consistency.
| @@ -188,6 +188,28 @@ def test_link_change_form(self): | |||
| self.assertNotContains(response, 'organization_id') | |||
| self.assertContains(response, link.topology.organization.name) | |||
|
|
|||
| def test_link_update_status(self): | |||
There was a problem hiding this comment.
Since this looks like a problem with the app which integrates with openwisp-controller, can you please move it to openwisp_network_topology.integrations.device.tests.TestAdmin to achieve proper isolation?
nemesifier
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #154