Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fixed "receive_url" field in TopologyAdmin #201

Merged
merged 3 commits into from
Jun 22, 2023

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented Jun 16, 2023

Bug:
When WiFi Mesh integration is enabled, opening the topology add view was generating Server 500 Error. The issue was caused because the topology instance for the ModelForm didn't have primary key set.

Fix:
Do not show "receive_url" field on add view.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remember to update the README as discussed, the rest is good.

Bug:
When WiFi Mesh integration is enabled, opening the topology add
view was generating Server 500 Error. The issue was caused because
the topology instance for the ModelForm didn't have primary key set.

Fix:
Do not show "receive_url" field on add view.
@coveralls
Copy link

Coverage Status

coverage: 99.344% (+0.002%) from 99.342% when pulling a32e201 on fix-topology-admin into f2df406 on master.

@nemesifier nemesifier merged commit 81c5b05 into master Jun 22, 2023
@nemesifier nemesifier deleted the fix-topology-admin branch June 22, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants