[change:radius] Replace third-party JSONField with Django built-in JSONField #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eeshu-Yadav
force-pushed
the
issues/600-replace-jsonfield-clean
branch
from
ae1c2d0 to
a9ad394
Compare
…ONField - Replaced jsonfield.JSONField with Django's built-in JSONField in models - Updated RadiusBatch.user_credentials field - Updated OrganizationRadiusSettings.sms_meta_data field - Removed third-party jsonfield dependency from setup.py - Added migration to handle field type transition - Updated test migrations to use Django's JSONField - Ensured backward compatibility and data preservation - All existing tests pass with the new implementation Fixes openwisp#600
Eeshu-Yadav
force-pushed
the
issues/600-replace-jsonfield-clean
branch
from
a9ad394 to
998b688
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Reference to Existing Issue
Closes #600.
Description of Changes
This PR replaces the third-party
jsonfieldlibrary with Django's built-in JSONField. The third-party JSONField library hasn't received updates in 5 years, while Django's built-in JSONField is now mature and actively maintained.Changes Made:
from jsonfield import JSONFieldwithfrom django.db.models import JSONFieldin modelsRadiusBatch.user_credentialsandOrganizationRadiusSettings.sms_meta_datafields"jsonfield~=3.1.0"dependency from setup.py0041_replace_jsonfield_with_django_builtin.pyto handle field type transitionTesting: