Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Upgraded QA dependencies #342

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented Jun 13, 2023

  • Bummped black~=23.3.0
  • Bumped flake8~=6.0.0
  • Bumped readme-renderer~=37.3.0
  • Bumped coveralls~=3.3.0

@pandafy pandafy added this to In progress in OpenWISP Contributor's Board Jun 13, 2023
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on the latest master.

Can you check whether upgrading black changes the formatting in other modules (eg: controller)?

@pandafy
Copy link
Member Author

pandafy commented Jun 20, 2023

Can you check whether upgrading black changes the formatting in other modules (eg: controller)?

Yes, it does.

@nemesifier
Copy link
Member

Can you check whether upgrading black changes the formatting in other modules (eg: controller)?

Yes, it does.

Can you please look if there is there any flag we can add to avoid that? Maybe when they changed the default they provided a way to override it.

@pandafy
Copy link
Member Author

pandafy commented Jun 20, 2023

@pandafy
Copy link
Member Author

pandafy commented Jun 21, 2023

Did you mean using the --required-version flag? It will only stop the execution of the black command.

Example from the [black documentation]:(https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#versions)

black --required-version 21.9b0 -c "format = 'this'"
format = "this"
black --required-version 31.5b2 -c "still = 'beta?!'"
Oh no! 💥 💔 💥 The required version does not match the running version!

- Bummped black~=23.3.0
- Bumped flake8~=6.0.0
- Bumped readme-renderer~=37.3.0
- Bumped coveralls~=3.3.0
@coveralls
Copy link

coveralls commented Jun 21, 2023

Coverage Status

coverage: 98.395%. remained the same
when pulling 29632b6 on update-qa-dependencies
into 2440f96 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants