Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Upgrade Django channels to 4.2 #435

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AviGawande
Copy link

@AviGawande AviGawande commented Feb 2, 2025

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

Closes #388 .

Please open a new issue if there isn't an existing issue yet.

Description of Changes

Please describe these changes.

Screenshot

Please include any relevant screenshots.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AviGawande do you really think if it was this easy we wouldn't have done it yet?
It costs less time to do this change than opening the issue.

Are you working on the other modules as well apart from this?

@coveralls
Copy link

Coverage Status

coverage: 96.18%. first build
when pulling d5a3ace on AviGawande:upgrade-django-channels
into 6c93115 on openwisp:master.

@AviGawande
Copy link
Author

yes i am working on this issue and i have opened Pull Request on Django_loci for channels==4.2

@nemesifier
Copy link
Member

@AviGawande thanks a lot for the clarification, can you please link all the PRs from the other modules/packages in a bullet list in the description of this PR? This will make it easier for us to navigate all the work linked to this. We can't merge this until we get all modules onboard or builds will start failing in other modules, causing issues to developers and contributors. Thank you 🙏

@AviGawande
Copy link
Author

Sure @nemesifier i am working on remaining modules one-by-one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Centralize django-channels dependency and upgrade to latest version
3 participants