2to3 #103
Open
2to3 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. data_reader, config_package, input_list, conns_to_include
So the optimizer can also add new parameters instead of only changing the magnitude. Therefore the unit needs to be known.
parameters['AVBR_to_DB1_elec_syn_gbase'] = {'value':'0.1', 'unit':'nS'}
self.volts['MDL01/0/GenericMuscleCell/v'] = [...]
Check if type of param is dict or list (new or old version).
Use multiprocessing.pool instead of parallelpython
This reverts commit 87bf234.
Conflicts: CElegans/pythonScripts/c302/tune/C302Simulation.py
Only override/add param by a regex unless there is a param defined without a regex.
new models, other changes
|
I've incorporated these updates into here: https://github.com/openworm/CElegansNeuroML/tree/ow-0.8_py3 & made more changes. Basic examples work for me in python3... @lungd can you test these before I merge into ow-0.8? |
|
The branch https://github.com/openworm/CElegansNeuroML/tree/ow-0.8_py3 seems to be working now that #105 is resolved. @slarson I'd suggest closing this PR and testing with the ow-0.8_py3 branch. |
|
@pgleeson OK; where should the ow-0.8_py3 branch be merged if it works? To master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades c302 to work with Python 3.6.