luci-app-pbr: sync with principal package #7267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stan Grishin <[email protected]>
stangri
added
the
depends on PR in other repo
krant
reviewed
Sep 15, 2024
| @@ -24,6 +24,6 @@ help | |||
| Version: $(PKG_VERSION)-$(PKG_RELEASE) | |||
| endef | |||
|
|
|||
| include ../../luci.mk | |||
| include $(TOPDIR)/feeds/luci/luci.mk | |||
There was a problem hiding this comment.
@stangri this change causing that in my local setup (and I'm not even building it):
ERROR: please fix package/feeds/applications/luci-app-pbr/Makefile - see logs/package/feeds/applications/luci-app-pbr/dump.txt for details
My luci.mk lives in openwrt/package/feeds/luci.mk and for all other packages it causes no problem.
There was a problem hiding this comment.
Thanks for the feedback, could you please provide the content of the logs/package/feeds/applications/luci-app-pbr/dump.txt?
There was a problem hiding this comment.
Here you are:
Makefile:27: /home/krant/openwrt/feeds/luci/luci.mk: No such file or directory
make[2]: *** No rule to make target '/home/krant/openwrt/feeds/luci/luci.mk'. Stop.
There was a problem hiding this comment.
@krant thanks for your prompt reply, I'll revert the change
stangri
added a commit
to stangri/luci
that referenced
this pull request
Sep 22, 2024
* fixes the build issue reported by @krant in comments to openwrt#7267 Signed-off-by: Stan Grishin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on openwrt/packages#24920
One update I'd like some feedback for is changing include of
luci.mkfrom relative to an absolute path, that was requested by some users of upstream repo. If it's going to be a problem in OpenWrt repo, please let me know.