Skip to content

dnscrypt-proxy: Changed 'Provider Key' for securedns to current value#11769

Merged
neheb merged 1 commit intoopenwrt:masterfrom
cbz:master
Apr 28, 2020
Merged

dnscrypt-proxy: Changed 'Provider Key' for securedns to current value#11769
neheb merged 1 commit intoopenwrt:masterfrom
cbz:master

Conversation

@cbz
Copy link
Copy Markdown

@cbz cbz commented Apr 5, 2020

Signed-off-by: Chris E cbz@pobox.com

Maintainer: me / @<github-user> (find it by checking history of the package Makefile)
Compile tested: mips_24kc / 19.07.02
Run tested: mips_24kc / 19.07.02

Description:

Changed key in resolver file for securedns.eu to match current value on https://securedns.eu/

@BKPepe
Copy link
Copy Markdown
Member

BKPepe commented Apr 5, 2020

You should send the pull request to upstream (https://github.com/dyne/dnscrypt-proxy/blob/master/dnscrypt-resolvers.csv#L102) first, because there it needs to be improved, too.

@cbz
Copy link
Copy Markdown
Author

cbz commented Apr 5, 2020

Given that the upstream hasn't been accepting changes since Jan 2018, this is an example of the best being the enemy of the good.

@BKPepe
Copy link
Copy Markdown
Member

BKPepe commented Apr 5, 2020

Honestly, I don't know, why you don't want to send it to upstream. The dnscrypt-proxy does not plan any new features and it should be maintained. I see the latest commit from August 2019 and there is a good change to have it fixed not just in OpenWrt, but for anyone, who is using dnscrypt-proxy from source code. Instead of arguing about it here, it could be done.

@cbz
Copy link
Copy Markdown
Author

cbz commented Apr 5, 2020

Did you actually take a look at the upstream? Because I did. The upstream's last change was 8 months ago, and the project build has been failing for almost as long. They last accepted a change to the resolvers file 2 years ago, which is why people have been forking it and updating their private copies.

They have two outstanding pull requests dating to November 2019 and March 2018, I don't think they are likely to respond particularly quickly.

@cbz
Copy link
Copy Markdown
Author

cbz commented Apr 5, 2020

Look at this issue - dyne/dnscrypt-proxy#15 - they aren't updating their CSV file any longer because the focus has moved to dnscrypt-proxy2

@neheb neheb merged commit 6db17c8 into openwrt:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants