Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libqmi: enable selection of message collections #12736

Closed
wants to merge 1 commit into from
Closed

libqmi: enable selection of message collections #12736

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 6, 2020

Maintainer: me
Compile tested: ath79 Telco T1 master
Run tested: ath79 Telco T1 master, checked basic functions

Description:

  • Added new message collections support, so that users can select which messages to include in the built library during configure with the --enable-collection option. Three predefined sets are given:
    • minimal: the bare minimum messages required to control connectivity.
    • basic: all messages and indications that ModemManager requires. (selected here by default)
    • full: all supported messages and indications.

More information: https://lists.freedesktop.org/archives/libqmi-devel/2020-June/003341.html

@neheb
Copy link
Contributor

neheb commented Jul 6, 2020

Needs a PKG_RELEASE bump.

@ghost
Copy link
Author

ghost commented Jul 6, 2020

Needs a PKG_RELEASE bump.

Thanks, done

@dangowrt
Copy link
Member

dangowrt commented Jul 6, 2020

Imho it'd be nicer to use package variants, so users can select at run-time rather than compile-time.

@ghost
Copy link
Author

ghost commented Jul 8, 2020

Imho it'd be nicer to use package variants, so users can select at run-time rather than compile-time.

I have been looking at that, and have a couple of questions. If we have three variants, libqmi-minimal/basic/full, how do we satisfy ModemManager's dependency on libqmi? ModemManager depends on at least libqmi-basic, it will not work with libqmi-minimal. Is there a way to create a wrapper package somehow so that MM is always satisfied?

@neheb
Copy link
Contributor

neheb commented Aug 31, 2020

Needs a rebase.

@feckert
Copy link
Member

feckert commented Dec 13, 2021

@nickberry17 You could work with PROVIDES please have a look to

PROVIDES:=mosquitto
who this works

@BKPepe BKPepe assigned ghost Feb 18, 2022
@BKPepe
Copy link
Member

BKPepe commented Apr 22, 2022

@nickberry17 Kind reminder, please.

@ghost ghost closed this May 2, 2024
@Neustradamus
Copy link

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants