Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wsdd2: #46 from upstream to fix interface selection #22550

Closed
wants to merge 1 commit into from

Conversation

rikka0w0
Copy link

@rikka0w0 rikka0w0 commented Oct 30, 2023

Fixes Netgear/wsdd2#36

Maintainer: @rikka0w0
Compile tested: ARMv7, Linksys wrt1900ac v2, OpenWrt 23.05.0
Run tested: ARMv7, Linksys wrt1900ac v2, OpenWrt 23.05.0, run for 3 hours to see if the server still becomes invisible.

Description:
In a ksmbd+wsdd2 configuration, the server becomes invisible to Windows 11 clients after a few minutes to a few hours.

This PR merges a pending PR Netgear/wsdd2#46 from the upstream repository to address this issue.

Copy link
Member

@BKPepe BKPepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI fails:

  1. Formality things:
: === Checking commit '3818766a2eff5ee05251e0ed9159536e1cf1c08a'
: Author name (rikka) need to be your real name 'firstname lastname'
: Commit subject line seems ok (wsdd2: #46 from upstream to fix interface selection)
: Signed-off-by is missing or doesn't match author (should be 'Signed-off-by: rikka <[email protected]>')
Error: Process completed with exit code 1.
  1. The patch imho not in this state.
    You need to backport the patch to include as much details as possible. Where is the Git header? Who is the author? What is the commit subject, description. etc.?

You need to use it by this way: https://patch-diff.githubusercontent.com/raw/Netgear/wsdd2/pull/46.patch

  1. You need to bump PKG_RELEASE.

  2. In my point of view, you don't to use two times the same reference in the commit.
    Once or do not do that. With each force push, you will only spam the issue/pull request.
    So, it's better to include the Fixes tag (GitHub keywords) in the pull request.

@sppmasterspp
Copy link

I've applied it as a patch to my local OpenWrt repository before compiling the firmware for my QNAP. This way the patch fixed wsdd2 package is built-in into the firmware image.
Finally It's working as it should right from the boot. Running for 80+ hours.
It's fully operational (nothing disappears anymore) on all Windows PCs and even on Android phones (I use Total Commander for Android with its LAN plugin to access SMB Windows shares).

Fixes Netgear/wsdd2#36

Backport of Netgear/wsdd2#46

In a ksmbd+wsdd2 configuration, the server becomes invisible to Windows 11
clients after a few minutes to a few hours.

This commit merges a pending PR Netgear/wsdd2#46 from the upstream repository
to address this issue.

Signed-off-by: Hang Zhou <[email protected]>
@rikka0w0
Copy link
Author

The wsdd2 upstream repo has merged the required patch, so please see #22943.

@rikka0w0 rikka0w0 closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows 11 disappears for a long time Samba
3 participants