Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openblas: enable ARM-specific optimizations #23443

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Conversation

krant
Copy link
Contributor

@krant krant commented Feb 16, 2024

Maintainer: @commodo
Run tested: arm_cortex-a9+neon, Linksys WRT3200ACM, master branch

@commodo
Copy link
Contributor

commodo commented Feb 16, 2024

PKG_RELEASE:=1 needs a bump

rest looks good

@BKPepe
Copy link
Member

BKPepe commented Feb 16, 2024

Commit description is missing - why do we need to have this change, what was the reason, how this is improvement, etc.

@krant
Copy link
Contributor Author

krant commented Feb 16, 2024

@commodo nice catch, done

@krant
Copy link
Contributor Author

krant commented Feb 16, 2024

@BKPepe look at the summary - it's all there

@commodo
Copy link
Contributor

commodo commented Feb 16, 2024

@BKPepe look at the summary - it's all there

so a commit description is nice to have :)
as a general overview of what the change does;

OpenBLAS has per-processor (well, per-family processor) optimizations in assembly;
but they need to be enabled specifically;
i did not bother to do it for each family;
when people want them, they can enable them (like in this patchset)

OpenBLAS allows to specify per-family CPU optimizations during build stage.
This package supports manual specification of a family during configuration.
This commit adds automatic detection of target family, while keeping manual
override as a backup.

Automatically detected ARM families:
 - Cortex-A9 without NEON
 - Cortex-A9 with NEON
 - Cortex-A15
 - Cortex-A53
 - Cortex-A72

Signed-off-by: krant <[email protected]>
@krant
Copy link
Contributor Author

krant commented Feb 16, 2024

@commodo thanks for being constructive. Commit has been updated.

@BKPepe BKPepe merged commit 8bcd244 into openwrt:master Feb 17, 2024
9 of 12 checks passed
@krant krant deleted the openblas branch February 20, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants