Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

procps-ng: update to version 4.0.4 and rename old version 3.3.16 to procps-ng3 #23457

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

feckert
Copy link
Member

@feckert feckert commented Feb 16, 2024

  • Revert commit 81629ba
  • Rename procps-ng to procps-ng3 and only install library .so file (no utilities) for downstream packges that use procps-ng library feature.
    • Update procps-ng3 to the latest version 3.3.17 of 3.x series
    • Refresh existing patch
  • Readd procps-ng version 4.0.3 of 4.x series

This is the result of discussion in #23230.
This pullrequest replaces pullrequest #23402

@feckert feckert changed the title Pr/20240216 procps ng Pr/20240216 procps-ng: update to version 4.0.4 and rename old version 3.3.16 to procps-ng3 Feb 16, 2024
@feckert feckert changed the title Pr/20240216 procps-ng: update to version 4.0.4 and rename old version 3.3.16 to procps-ng3 procps-ng: update to version 4.0.4 and rename old version 3.3.16 to procps-ng3 Feb 16, 2024
The props-ng packages adds a new API version that breaks other
downstream packages. This revert is a preparation commit to move the old
API to procps-ng3 so that the new API could use procps-ng packages
name again.

Signed-off-by: Florian Eckert <[email protected]>

This reverts commit 81629ba.
Signed-off-by: krant <[email protected]>

- Rebase patch because of packages version update was reverted before

Signed-off-by: Florian Eckert <[email protected]>
- Install library only (utilities are in procps-ng API version 4)
- Latest 3.3.17 version of 3.x series is used
- Refresh existing patch
- Add new patch from Alpine Linux

Signed-off-by: krant <[email protected]>

- Rebase patch because of packages version update was reverted before

Signed-off-by: Florian Eckert <[email protected]>
@BKPepe
Copy link
Member

BKPepe commented Feb 16, 2024

Oh boy... another thing, which needs to be handled, which was caused that someone wants to have the latest version of everything without proper testing... :-/

@BKPepe BKPepe self-assigned this Feb 16, 2024
@krant
Copy link
Contributor

krant commented Feb 16, 2024

@BKPepe your comments as usually are non-constructive, attacking someone personally and painfully wrong. This specific upgrade caused breakage of some unspecified out-of-tree software relying on development branch of this repo. How do you suppose we had to find this specific breakage without updating the master? You have no answer, since your common stance is to ignore the questions and intervene only to bully or to gatekeep someones work. This exact attitude has led to enormous number of outdated packages, some of which has not been updated for 2, 3 or even 5 years. If instead of rambling in each thread how busy you're you spend some time, you know, maintaining - OpenWrt packages had not been a such a disaster.

@feckert feckert merged commit aa7b4e3 into openwrt:master Feb 16, 2024
7 of 12 checks passed
@feckert feckert deleted the pr/20240216-procps-ng branch February 16, 2024 14:03
@BKPepe
Copy link
Member

BKPepe commented Feb 16, 2024 via email

@krant
Copy link
Contributor

krant commented Feb 16, 2024

There are no quality in years-dated software with a lot of known bugs and CVEs. Having it on the edge devices which are primary target of OpenWrt is the opposite of quality.
Regarding my testing - you're again assumed bad intentions in someone, what a surprise (it is not). But I open you the secret - I have fast multicore CPU, so I could iterate quickly, and my run tests are very simple - I just.. run the software on my router. By the way, it is the same router I use for the Internet access, that's how reckless I'm.
Let me stop interacting with you - as I've predicted, you've ignored straight-to-the-topic question in my previous comment. If you want to lecture me about your views on software development - first point me to the specific clause of official OpenWrt documentation which my commits you think are violating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants