knot-resolver: fix make config #24060
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i forgot this required |
|
@autobakterie the build docker image doesn't seem to have |
|
PKG_RELEASE bump is needed. |
facboy
force-pushed
the
knot-resolver
branch
2 times, most recently
from
d508699
to
0ee46c7
Compare
|
Thx fixed. |
* Fix errors in make config preventing e.g. `menuconfig` from working, and `knot-resolver` from being included in builds * Disable `dnstap` by default as the docker build images do not have `protobuf-c-compiler` installed, so the build fails Signed-off-by: Christopher Ng <[email protected]>
facboy
force-pushed
the
knot-resolver
branch
from
eb92809
to
2deda3e
Compare
Signed-off-by: Christopher Ng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
menuconfigfrom working, andknot-resolverfrom being included in buildsMaintainer: @miska
Build system: x86/64
Compile tested: rockchip/armv8, nanopi-r4s, be37ab6 snapshot build
Run tested: rockchip/armv8, nanopi-r4s, be37ab6 snapshot build, running on my main router