Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tailscale: build with less features #24706

Closed
wants to merge 2 commits into from
Closed

tailscale: build with less features #24706

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05c9ac9
tailscale: build with less features
mochaaP Jul 31, 2024
a6cef4a
tailscale: update package maintainer
mochaaP Aug 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions net/tailscale/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ include $(TOPDIR)/rules.mk

PKG_NAME:=tailscale
PKG_VERSION:=1.70.0
PKG_RELEASE:=1
PKG_RELEASE:=2

PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
PKG_SOURCE_URL:=https://codeload.github.com/tailscale/tailscale/tar.gz/v$(PKG_VERSION)?
PKG_HASH:=8429728708f9694534489daa0a30af58be67f25742597940e7613793275c738f

PKG_MAINTAINER:=Jan Pavlinec <[email protected]>
PKG_MAINTAINER:=Zeyphy Lykos <[email protected]>
PKG_LICENSE:=BSD-3-Clause
PKG_LICENSE_FILES:=LICENSE

Expand All @@ -28,7 +28,7 @@ GO_PKG:=\
tailscale.com/cmd/tailscaled
GO_PKG_LDFLAGS:=-X 'tailscale.com/version.longStamp=$(PKG_VERSION)-$(PKG_RELEASE) (OpenWrt)'
GO_PKG_LDFLAGS_X:=tailscale.com/version.shortStamp=$(PKG_VERSION)
GO_PKG_TAGS:=ts_include_cli
GO_PKG_TAGS:=ts_include_cli,ts_omit_aws,ts_omit_bird,ts_omit_tap,ts_omit_kube,ts_omit_completion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, you added commit description exactly the same as it is in the pull request, but still you have decided to build it with less features, you pointed us to https://github.com/tailscale/tailscale/blob/main/build_dist.sh#L40 and still I am not sure what was the reason to have fewer features.

While looking at https://openwrt.org/submitting-patches, I see:

It should explain to a competent reader why you made this commit.


include $(INCLUDE_DIR)/package.mk
include ../../lang/golang/golang-package.mk
Expand Down
Loading