Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add respawn to mdns-repeater init #24772

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

adipierro
Copy link
Contributor

@adipierro adipierro commented Aug 12, 2024

Maintainer: @axkg
Compile tested: aarch64_cortex-a53, Xiaomi AX6S, snapshot, 23.05.4
Run tested: 23.05.4, snapshot, ramips (Xiaomi Mi Router 4A Gigabit Edition), aarch64_cortex-a53 (AX6S)

Description:
Added respawn to procd parameters with default options.

Sometimes mdns-repeater quits or crashes, leaving service stopped, requiring manual (re)start. This commit should fix that – and I use this patch this on all my openwrt routers for nearly a year.

@axkg
Copy link
Contributor

axkg commented Aug 14, 2024

Thanks for your contribution @adipierro - you fix works fine for me!

@adipierro
Copy link
Contributor Author

Hey @axkg, could you perhaps merge this? Seems like some checks require a review, and unfortunately for some reason I can't request it...

@axkg
Copy link
Contributor

axkg commented Sep 2, 2024

Not sure why I see two commits, in any case I approved both but I lack write access as well. @1715173329: Would you be so kind to merge this PR?

@1715173329
Copy link
Member

Please rebase your PR, and format your commit.
Commit title shoud start with <package name>: , and sign the DCO with vaild email instead of users.noreply.github.com.

@adipierro
Copy link
Contributor Author

Okay, finally I learned how to use git correctly 😅

@1715173329 could you please check if PR is OK for merge now? Thank you <3

Copy link
Member

@1715173329 1715173329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please increase PKG_RELEASE as well, FYI:
https://openwrt.org/docs/guide-developer/packages#buildpackage_variables

otherwise LGTM

Sometimes mdns-repeater quits or crashes, leaving service stopped. This commit should fix that by enabling respawn in procd.

Signed-off-by: Tina DiPierro <[email protected]>
@adipierro
Copy link
Contributor Author

thank you for letting me know – I increased PKG_RELEASE as well

@1715173329 1715173329 merged commit c703510 into openwrt:master Sep 16, 2024
13 checks passed
@1715173329
Copy link
Member

Merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants