-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add respawn to mdns-repeater init #24772
Conversation
Thanks for your contribution @adipierro - you fix works fine for me! |
Hey @axkg, could you perhaps merge this? Seems like some checks require a review, and unfortunately for some reason I can't request it... |
Not sure why I see two commits, in any case I approved both but I lack write access as well. @1715173329: Would you be so kind to merge this PR? |
Please rebase your PR, and format your commit. |
3e38317
to
5d0c45a
Compare
Okay, finally I learned how to use git correctly 😅 @1715173329 could you please check if PR is OK for merge now? Thank you <3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please increase PKG_RELEASE as well, FYI:
https://openwrt.org/docs/guide-developer/packages#buildpackage_variables
otherwise LGTM
Sometimes mdns-repeater quits or crashes, leaving service stopped. This commit should fix that by enabling respawn in procd. Signed-off-by: Tina DiPierro <[email protected]>
thank you for letting me know – I increased |
Merged, thank you! |
Maintainer: @axkg
Compile tested: aarch64_cortex-a53, Xiaomi AX6S, snapshot, 23.05.4
Run tested: 23.05.4, snapshot, ramips (Xiaomi Mi Router 4A Gigabit Edition), aarch64_cortex-a53 (AX6S)
Description:
Added
respawn
to procd parameters with default options.Sometimes
mdns-repeater
quits or crashes, leaving service stopped, requiring manual (re)start. This commit should fix that – and I use this patch this on all my openwrt routers for nearly a year.