openssh: Use apk-compatible versioning

[hnyman]

Adjust openssh's versioning to be compatible with apk: 8.9p1-r2 --> 8.9_p1-r2

"_p" is an allowed semantic suffix, so use that, although the p in upstream versioning means "portable" instead of patch level.

(Alternative might have been 8.9.1-r2)

PKG_REALVERSION will have the upstream version and internal PKG_VERSION is calculated from that.

Maintainer: nobody
Compile & run tested: mediatek/filogic MT6000 r27279-8b6c63cfaf

[github-actions]

OpenWrt will change to the APK package manager which requires
deterministic verisons. Please make sure that PKG_VERSION
follows Semantic Versioning or more specifically,
the APK version scheme.
If the version is based on a date, please use dots instead of dashes, i.e. 24.01.01.

The PKG_RELEASE should be an integer and not contain any letters or special characters.

• net/openssh/Makefile

[hnyman]

@aparcar
Funny, the CI rejects the PKG_VERSION although apk itself accepts that.

PKG_REALVERSION:=9.8p1
PKG_VERSION:=$(subst p,_p,$(PKG_REALVERSION))

in router the version is tested ok by apk, (and the OpenWrt build system also accepted it into the image)

root@router6000:~# apk version -c 8.9_p1-r2
root@router6000:~#

The CI apparently does not evaluate a calculated PKG_VERSION correctly...
Apparently it should be manually set in order to avoid CI trouble also in future.

[neheb]

PKG_VERSION:=$(subst p,_p,$(PKG_REALVERSION))

[hnyman]

That was my original approach in e655193, but CI rejected it, so I moved to manual strategy to avoid CI trouble in future...

[neheb]

hmm? That should evaluate to the same thing.

[hnyman]

Well, in actual make it does evaluate ok (and was ok in my original commit), but the CI workflow takes the string from Makefile as it is, and passes it to apk for verification, so using variables fails in CI.

packages/.github/workflows/check-apk-valid-version.yml

Line 56 in f9b1adf

PKG_VERSION=$(grep -E '^PKG_VERSION' "$ROOT/Makefile" | cut -f 2 -d '=')

I had it with "subst" in e655193 , but dropped that to avoid CI trouble in all forthcoming version upgrades.