Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uhubctl: update to 2.6.0 #24907

Merged
merged 1 commit into from
Sep 1, 2024
Merged

uhubctl: update to 2.6.0 #24907

merged 1 commit into from
Sep 1, 2024

Conversation

bluecmd
Copy link
Contributor

@bluecmd bluecmd commented Sep 1, 2024

Maintainer: @snh
Compile tested: OpenWrt master, mips64 octeon
Run tested: OpenWrt master, mips64 octeon

Description:
New release containing among other things the patches mentioned in #24734.

Testing:

root@oob-lab-sw1:~# uhubctl -v
2.6.0
root@oob-lab-sw1:~# uhubctl
Current status for hub 4 [1d6b:0003 Linux 6.6.39 xhci-hcd xHCI Host Controller 0000:01:00.0, USB 3.00, 2 ports, ppps]
  Port 1: 02a0 power 5gbps Rx.Detect
  Port 2: 02a0 power 5gbps Rx.Detect
Current status for hub 3 [1d6b:0002 Linux 6.6.39 xhci-hcd xHCI Host Controller 0000:01:00.0, USB 2.00, 2 ports, ppps]
  Port 1: 0503 power highspeed enable connect [0403:6011 FTDI USB <-> Serial Cable FTYICQ95]
  Port 2: 0503 power highspeed enable connect [0bda:b812 Realtek 802.11ac NIC 123456]
root@oob-lab-sw1:~# uhubctl --help 2>&1 | grep sysfs
--nosysfs,  -S - do not use the Linux sysfs port disable interface.
root@oob-lab-sw1:~# 

Signed-off-by: Christian Svensson <[email protected]>
@bluecmd bluecmd marked this pull request as ready for review September 1, 2024 10:33
Copy link
Contributor

@snh snh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this version bump, as well as the upstream fixes @bluecmd ❤️

@bluecmd
Copy link
Contributor Author

bluecmd commented Sep 1, 2024

For completness sake, I also tested this on a QEMU OpenWrt on x86_64:

bluecmd@oob-lab-sw3:~$ sudo uhubctl  -f
Current status for hub 7 [1d6b:0001 Linux 6.6.39 uhci_hcd UHCI Host Controller 0000:00:1d.1, USB 1.10, 2 ports, nops]
  Port 1: 0100 power
  Port 2: 0100 power
Current status for hub 2 [1d6b:0001 Linux 6.6.39 uhci_hcd UHCI Host Controller 0000:00:1a.0, USB 1.10, 2 ports, nops]
  Port 1: 0100 power
  Port 2: 0100 power
Current status for hub 4 [1d6b:0001 Linux 6.6.39 uhci_hcd UHCI Host Controller 0000:00:1a.1, USB 1.10, 2 ports, nops]
  Port 1: 0100 power
  Port 2: 0100 power
Current status for hub 6 [1d6b:0001 Linux 6.6.39 uhci_hcd UHCI Host Controller 0000:00:1d.0, USB 1.10, 2 ports, nops]
  Port 1: 0100 power
  Port 2: 0100 power
Current status for hub 8 [1d6b:0001 Linux 6.6.39 uhci_hcd UHCI Host Controller 0000:00:1d.2, USB 1.10, 2 ports, nops]
  Port 1: 0100 power
  Port 2: 0100 power
Current status for hub 1 [1d6b:0002 Linux 6.6.39 ehci_hcd EHCI Host Controller 0000:00:1a.7, USB 2.00, 6 ports, nops]
  Port 1: 0100 power
  Port 2: 0100 power
  Port 3: 0100 power
  Port 4: 0100 power
  Port 5: 0100 power
  Port 6: 0100 power
Current status for hub 3 [1d6b:0002 Linux 6.6.39 ehci_hcd EHCI Host Controller 0000:00:1d.7, USB 2.00, 6 ports, nops]
  Port 1: 0503 power highspeed enable connect [0627:0001 QEMU QEMU USB Tablet 28754-0000:00:1d.7-1]
  Port 2: 0100 power
  Port 3: 0100 power
  Port 4: 0100 power
  Port 5: 0100 power
  Port 6: 0100 power
Current status for hub 5 [1d6b:0001 Linux 6.6.39 uhci_hcd UHCI Host Controller 0000:00:1a.2, USB 1.10, 2 ports, nops]
  Port 1: 0100 power
  Port 2: 0100 power
bluecmd@oob-lab-sw3:~$ sudo uhubctl  -v
2.6.0

No port that actually supports power-cycling as it is a virtual USB, but it seems to work with the endian fixes without issue so should be fine on both LE and BE systems.

@hnyman hnyman merged commit 16bfadd into openwrt:master Sep 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants