ntpd: disable autoreconf fixup #24921
Conversation
Fixes openwrt#24918 which got introduced with openwrt c364cb8. Credit for the fix goes to Hirokazu MORIKAWA. Signed-off-by: Christian Svensson <[email protected]>
In Gluon's Github Actions CI, we were occasionally seeing bizarre build errors that looked like a config.sub file had been corrupted, or changed while it was being executed. The cause turned out to be an interaction of the symlinks created by autoreconf (pointing from individual tools' build dirs into `staging_dir/host/share/automake-1.16`) and OpenWrt's host-build.mk, which replaced config.guess and config.sub *after* autoreconf. The result was that the replacement of these files ended up following the symlinks and writing the files in `staging_dir/host/share/automake-1.16` instead of a package's build dir. This could cause other packages' builds to fail if they were currently executing the scripts while they were being written. To fix this, disable autoreconf's symlinking feature, so that modifying these files in a package's build directory can't accidentally affect the staged versions. Link: #15825 Signed-off-by: Matthias Schiffer <[email protected]>
| @@ -19,7 +19,6 @@ PKG_LICENSE:=NTP | |||
| PKG_LICENSE_FILES:=COPYRIGHT html/copyright.html | |||
| PKG_CPE_ID:=cpe:/a:ntp:ntp | |||
|
|
|||
| PKG_FIXUP:=autoreconf | |||
There was a problem hiding this comment.
@neheb Sorry, I've missed this pull request, just noticed it via the closure of #24918, so take this as a kind of post review :)
IMO this is not a proper fix, but rather a workaround. There is probably something wrong with the autofoo (or the package in general) and should be investigated and fixed by other means.
In other words, the PKG_FIXUP:=autoreconf is correct, probably should be default for all packages, because we certainly dont want to use autofoo as being shipped, but generate those by our tools/versions.
There was a problem hiding this comment.
Additionally I would like to point out, that those autofoo fixes were backported into 23.05 openwrt/openwrt@d811a09 and openwrt/openwrt@c4c43c6, thus we're looking for some ntpd package fix which might be backported there as well.
There was a problem hiding this comment.
I’ve done many autoreconf removals here. I see no problem with it.
There was a problem hiding this comment.
Is there any better solution for now? Currently, this package is not compiled in OpenWrt 23.05 and it would be great to be fixed there.
There was a problem hiding this comment.
Is there any better solution for now?
Not yet openwrt/openwrt#15825 (comment), but likely the autofoo in the package would need to be patched.
this package is not compiled in OpenWrt 23.05
You mean when compiled in the tree? I don't see that package in the faillogs-23.05, but I've checked just few architectures.
This is workaround currently used in OpenWrt master branch. Proper fix will probably be introduced in the future. Ref: - openwrt/packages#24921
Maintainer: @ffontaine @hauke @knthm
Compile tested: x86_64 & octeon, master
Run tested: x86_64 & octeon, master
Description:
Fixes #24918 which got introduced with openwrt c364cb8.
Credit for the fix goes to Hirokazu MORIKAWA.
Test: