ddns-scripts: add colon char in DNS_CHARSET

[xxxxxliil]

Maintainer: @feckert
Compile tested: N/A. (Runtime package script only)
Run tested: (amd64, ibm comp PC, OpenWrt 23.04, tests done)

Description:
IPv6 is separated by : instead of ., so we need to add : in DNS_CHARSET to fix issue #25051 or #25051

Signed-off-by: Xiaolong Zhang [email protected]

[feckert]

• Please bump the PKG_RELEASE by one.
• Please add a valid Signed-off-by with your correct name.
• Please add valid commit messages why we need to add ':' to the CHARSET so we could see in Git why we have to add this. A reference to the issue is not enough

[1715173329]

Please add a space between your last name and first name, thanks.

[xxxxxliil]

Please add a space between your last name and first name, thanks.

What if there is only first name?

[xxxxxliil]

@feckert @1715173329 What else do I need to do?

[feckert]

I do not speak Chinese! But deepl.com says '行旅途' means 'travel destination'.
And I don't know how the names are constructed in china.
CI/CD still complains
These are the rules sorry

[xxxxxliil]

CI/CD still complains
These are the rules sorry

How do I change to fit the rules?

[1715173329]

Sign DCO with your legal name, at least, looks legal.
And nowadays I don't think any legal Chinese name does not contain last name.
I guess "行旅途" means "go travel".

[xxxxxliil]

Sign DCO with your legal name, at least, looks legal.

Can I only sign with my legal name? I would prefer to contribute anonymously.

[1715173329]

These are the rules sorry

[xxxxxliil]

These are the rules sorry

sad

[xxxxxliil]

@feckert @1715173329 If you have time please approve the inspection.

[feckert]

Looks good. Just a little nit pick, then we can merge. Can you please limit the commit message to 80 characters per line and remove the second mention of #25051. This does not need to be written twice in the commit message.

[xxxxxliil]

...and remove the second mention of #25051. This does not need to be written twice in the commit message.

If you look in git, it's actually a github issue link and the string #25051. I'll keep only one if you ask me to keep only one though.

[feckert]

Using git cmd on the shell I see:

IPv6 is separated by `:` instead of `.`, so we need to add `:` in DNS_CHARSET to fix issue #25051
or https://github.com/openwrt/packages/issues/25051

On the github WebUI I see:

IPv6 is separated by `:` instead of `.`, so we need to add `:` in DNS_CHARSET to fix issue #25051
or #25051

Please write https://github.com/openwrt/packages/issues/25051 so no github user also can see the link. On the github WebUI the link is auto resolved. Therefore #25051 appears twice.

[feckert]

Also I see in my git history:
2024-09-30 03:46 +0800 行旅途 o [pr/upstream-25056] ddns-scripts: add colon char in DNS_CHARSET

But in the commit message you have added the line
Signed-off-by: Xiaolong Zhang <[email protected]>

I think if I start running the CI/CD then this will not be happy and will complain Test Formalities / Test Formalities (pull_request)
You have to update your .gitconfig with the name in your Signed-off-by line so we have.

[user]
name = Xiaolong Zhang
email = [email protected]

Then add the change wit git add <file> and after that execute git commit -s. This will add a valid Signed-off-by and the correct auther to the repository so we have.

2024-09-30 03:46 +0800 Xiaolong Zhang o [pr/upstream-25056] ddns-scripts: add colon char in DNS_CHARSET

[xxxxxliil]

Also I see in my git history: 2024-09-30 03:46 +0800 行旅途 o [pr/upstream-25056] ddns-scripts: add colon char in DNS_CHARSET

But in the commit message you have added the line Signed-off-by: Xiaolong Zhang <[email protected]>

I think if I start running the CI/CD then this will not be happy and will complain Test Formalities / Test Formalities (pull_request) You have to update your .gitconfig with the name in your Signed-off-by line so we have.

[user]
name = Xiaolong Zhang
email = [email protected]

Then add the change wit git add <file> and after that execute git commit -s. This will add a valid Signed-off-by and the correct auther to the repository so we have.

2024-09-30 03:46 +0800 Xiaolong Zhang o [pr/upstream-25056] ddns-scripts: add colon char in DNS_CHARSET

The corresponding operation for submitting through GitHub codespace is to change your name in GitHub and enter git commit --author=... --amend -asS in the terminal to edit the submission again and sign it with pgp.

Anyway, I finally completed the CI/CD name requirement, but it was a bit cumbersome.

[feckert]

I Update the commit message und also bumped the PKG_RELEASE number and pushed directly
b962029
Thanks for your work -> merged

[Neustradamus]

@xxxxxliil: Good job!

@feckert: I think it can be backported in 24.10.x and 23.05.x?

[feckert]

Already backported with commit e95262a

[Neustradamus]

@feckert: Thanks :)