openwisp-config: fix Makefile for 1.1.0 #25186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2024
nemesifier
reviewed
Oct 24, 2024
There was a problem hiding this comment.
@feckert we fixed some issues and updated some outdated code here.
|
Any maintainer could merge this please? @BKPepe |
BKPepe
reviewed
Oct 29, 2024
BKPepe
reviewed
Oct 29, 2024
BKPepe
reviewed
Oct 29, 2024
BKPepe
reviewed
Oct 29, 2024
pandafy
force-pushed
the
fix-openwisp-config-1.1
branch
from
0a9b79f
to
b3940fa
Compare
|
@BKPepe Do you have any comments or can I merge this? |
|
Yep, I do. :) There is missing PKG_RELEASE in the Makefile. |
BKPepe
reviewed
Nov 6, 2024
Update configuration in Makefile to fix openwrt#25168. Add "/etc/openwisp/" to conf files. Signed-off-by: Gagan Deep <[email protected]>
pandafy
force-pushed
the
fix-openwisp-config-1.1
branch
from
b3940fa
to
86347b6
Compare
|
I would also suggest to bump the PKG_RLEASE by one. Everything else looks good to me. |
pandafy
commented
Nov 8, 2024
|
Thanks merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update configuration in Makefile to fix #25168
Maintainer: @nemesifier
Compile tested: ramips
Run tested: ramips