Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netatalk: Remove apfstats feature to solve dependency issues #25251

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

APCCV
Copy link
Contributor

@APCCV APCCV commented Nov 4, 2024

Maintainer: me / @APCCV
Compile tested: snapshot SDK ipq806x
Run tested: C2600 - snapshot. Run afpd, file sharing.

Description:
afpstats requires several libraries that would increase significantly final install size.
Eliminating from build removes dependency on GLIBC.
Fixed a typo in description define (that typo has been there for over 10 years...)

@APCCV
Copy link
Contributor Author

APCCV commented Nov 4, 2024

I cannot replicate the buildbot error. This thing always builds successfully.
Tried w/SDK. Tried a full snapshot image build for a C2600. Fresh git clones both, so no cached libraries. All successful.
In theory this is the only feature that is active that requires glibc. In theory if the library is not available the feature is not built.
If it is not present as an argument is assumed as true by meson build. Set is as explicitly as false. "0" doesn't work. Must be "false".
I can see an additional command line 'afpstats' utility built no matter what. There is no way to avoid it but to patch the build script. So...as I think this is enough to solve the problem, here goes a PR. It should work.
If it doesn't I can patch the script to take the additional command line utility out.
I'll bring the issue to netatalk so it can be addressed upstream.

@APCCV
Copy link
Contributor Author

APCCV commented Nov 4, 2024

Feature compiled as OFF as per logs from successful CI/CD tests:

...
2024-11-04T22:37:58.3826715Z     Features:
2024-11-04T22:37:58.3827042Z       ACL                      : NO
2024-11-04T22:37:58.3827667Z       AFP stats via D-Bus      : NO
2024-11-04T22:37:58.3828147Z       AppleTalk                : YES
...

Confirmed from build scripts that the afpstats feature is what pulls in the missing dependencies:

    afpd_external_deps += [
        dbus,
        gio,  
        glib,
        gobject,
    ]

Adding those four dependencies for a small utility that could eventually be used to create a netatalk status section in Luci is too much bloat.

I am confident this PR will clear the dependencies issue. Please proceed with merge.

@APCCV APCCV mentioned this pull request Nov 4, 2024
afpstats requires several libraries that would increase significantly final install size.

Signed-off-by: Antonio Pastor <[email protected]>
@hnyman hnyman merged commit 07efd50 into openwrt:master Nov 5, 2024
12 of 17 checks passed
@Neustradamus
Copy link

Thanks to @APCCV and @hnyman for merging!

Original PRs in master:

24.10 backport:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants