ddns-scripts: Adjust descriptions in Makefile for apk (no parentheses inside double quotes) #25293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having both double quotes and parentheses in package
description may lead into troublewith apk, if parentheses
are located so that they get passed "outside" the quoted
parameter, and get interpreted as a token for shell.
Example:
ash: -c: line 1: syntax error near unexpected token `('
bash: -c: line 1: `/OpenWrt/e8450/staging_dir/host/bin/fakeroot
/OpenWrt/e8450/staging_dir/host/bin/apk mkpkg --info "name:ddns
-scripts-pdns" --info "version:2.8.2-r51" --info "description:D
ynamic DNS Client scripts extension for "PowerDNS" via API. It
requires: "option param_opt(Optional Parameter)" to be a valid
Avoid that by using single quotes in the detailed descriptions.
Signed-off-by: Hannu Nyman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having both double quotes and parentheses in package description may lead into trouble with apk, if parentheses are located so that they get passed "outside" the quoted parameter, and get interpreted as a token for shell.
Example, where quoted text containing parentheses
"option param_opt(Optional Parameter)"gets handled wrong, as the 'opening quote' is actually the closing quote from shell perspective and thus ( is seen as a shell delimiter:Avoid that by using single quotes in the detailed descriptions in Makefile.
I am doing this change as a PR to document this behavior better for future.