Avoid the second basic propagation iteration to confirm convergence in production builds. #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_731657369
branch
3 times, most recently
from
1a2f490 to
c078f70
Compare
…n production builds. We know that a single iteration is enough to converge as we add affected ops back to the worklist. Removing the extra iteration for convergence check reduces the pass time by ~33%. This would also allow op priority propagation to have more iterations without the overhead of the extra convergence check iteration. In debug builds, we won't fail if failed to converge, but issue a warning instead. In addition, remove strided view warning as we no longer need it to know there are cases that would benefit from support. PiperOrigin-RevId: 732412330
copybara-service
bot
force-pushed
the
test_731657369
branch
from
c078f70 to
d564374
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid the second basic propagation iteration to confirm convergence in production builds.
We know that a single iteration is enough to converge as we add affected ops back to the worklist. Removing the extra iteration for convergence check reduces the pass time by ~33%. This would also allow op priority propagation to have more iterations without the overhead of the extra convergence check iteration.
In debug builds, we won't fail if failed to converge, but issue a warning instead.
In addition, remove strided view warning as we no longer need it to know there are cases that would benefit from support.