[XLA:MSA] Fixes an issue that leads to sync mem op replacements not respecting the auxiliary control dependencies while converting sync mem ops to async #23276
+63
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_732288966
branch
4 times, most recently
from
4528217 to
6242cbb
Compare
…especting the auxiliary control dependencies while converting sync mem ops to async MSA assumes all control dependencies (predesseccors/successors) are met in earlier passes by the scheduler. Therefore, it traditionally only respects the data flow dependencies (i.e., instruction.uses()). This became problematic when we replaced sync copies with async ones: the async copies where not aware of indirect control dependencies when we were determining their latest allowed copy-done time. PiperOrigin-RevId: 732288966
copybara-service
bot
force-pushed
the
test_732288966
branch
from
6242cbb to
71418c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[XLA:MSA] Fixes an issue that leads to sync mem op replacements not respecting the auxiliary control dependencies while converting sync mem ops to async
MSA assumes all control dependencies (predesseccors/successors) are met in earlier passes by the scheduler. Therefore, it traditionally only respects the data flow dependencies (i.e., instruction.uses()). This became problematic when we replaced sync copies with async ones: the async copies where not aware of indirect control dependencies when we were determining their latest allowed copy-done time.