Test and fix issues with CseConstantKey. #34793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_839983692
branch
4 times, most recently
from
730631a to
32fadc9
Compare
HLO CSE ConstantKey was not tested. There is at least one case where two ConstantKeys can be equal (according to operator==) but have different hashes. This change adds a test and fixes the hashing. PiperOrigin-RevId: 840802202
copybara-service
bot
force-pushed
the
test_839983692
branch
from
32fadc9 to
cc7ce8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test and fix issues with CseConstantKey.
HLO CSE ConstantKey was not tested. There is at least one case where two
ConstantKeys can be equal (according to operator==) but have different hashes.
This change adds a test and fixes the hashing.