-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openzfs/zfs#14611] Fix missing install from source steps. #400
base: master
Are you sure you want to change the base?
Conversation
This "tutorial" is based on my PoC and HomeLab installation via Ansible tested on ubuntu server 22.10. |
Will need to update docs according to #396 |
Why don't we just add part about services (and other small nits) into Building ZFS.rst as additional section? Looks like a duplicate otherwise, we already have 2 instructions about building from source. |
So maybe we should merge them into one covering all details? |
@gmelikov I'll prepare something (merged doc) according to the docs and my knowledge. |
@aamkye yes, I've meant that we may just add needed things to existing page. Side note - while it may be handy, I don't think it would be great to add parts about ansible. We may describe ansible somewhere else and add a link to it (maybe whole playbook example as yaml file? But we'll need to maintain it). |
Valid point Sir! So let's stick to bash commands and bash commands only in this repo :) |
Just to be on the same page, we already have:
I think the best place is https://openzfs.github.io/openzfs-docs/Developer%20Resources/Custom%20Packages.html , because the point is to get working custom packages, not just build modules. |
@gmelikov I've also found that besides missing services there are also a missing cron jobs:
I think it also should be part of the documentation, shouldn't it? |
@aamkye in fact, there are 2 types of packages in any project:
So, we may describe explicitly about such difference, and that our documentation speaks about first type. That mean is that (for example in Debian) if you want to get 100% identical package to original distro's one - you need to rebuild from distro's source package, not project's one. If project's package misses something - we may discuss to add missing parts in our packages. So, any of additions in docs may describe just notes about which functionality may be added, but we should now describe them as "must haves" (because in this case we should add them into packages, not into documentation). You may be interested to read this thread with Debian's package maintainer openzfs/zfs#13451 |
@gmelikov, I was investigating the deb package from ubuntu ( user@server:~$ systemctl cat zfs [tab]
zfs-import-cache.service zfs-load-key.service [email protected] zfs-volume-wait.service
zfs-import-scan.service zfs-mount.service zfs-share.service zfs-zed.service
zfs-import.service [email protected] zfs.target
zfs-import.target [email protected] zfs-volumes.target And if fact those services and timers are present in the system. Going further, on the Right now I'm trying to determine a common sense, but any clarification would be helpful in favor of future documentation. Another issue is the fact that |
Yep, that's exactly what I'm talking about - every Linux distribution may have it's own package with differences and patches. We even can't describe uniform deb info because Ubuntu, Debian and Proxmox all have their own packages. |
So maybe as a ZFS community, we could gather people from different distros and prepare a repository to prepare such packaging for each distribution containing guidelines, tutorials, and scripts to do so not only for the ZFS project but for more. Because it seems I've entered a rabbit hole and it goes waaaaay deeper than I thought. |
It's true that we may gather good and universal parts together in our original packages, but it's normal for major distribution to have alterations in packages. I can add even more - Debian maintainers want to use their own packages even after native debs were pulled into our master (it's ok to track package build parts separately from upstream project). So, we can highlight these things in documentation:
|
I was missing this info, so I'm glad to provide them :)
Please let me know if certain information is missing.