add debian10 arm64 slaves #203
Conversation
I've noticed that there has been a small handful of issues with GPL violations on arm64 over the past year or so. It seems like this is something we can catch by leveraging the AWS graviton arm64 instances for build slaves.
|
I'll call out right at the get go that I have no idea how to test this change, since I think a lot of the magic for actually running the buildbot setup requires access to some ec2 accounts and more understanding than I was able to piece together from the docs. I'm happy to spend more time iterating on this to get it right if someone can provide me the guidance on what I can do to be more confident about the change. |
|
Some examples of the types of issues I'm hoping this will help catch: |
|
I completely agree we should start using the graviton arm64 instances to catch this kind of thing. In fact there's a similar change for FreeBSD #199 pending. Unfortunately testing this kind of change is a bit problematic. I'm swamped right now, but I can probably test it out in a few weeks. |
Since this is available in more regions (including us-west-1).
On some instances (eg c6) we don't have local disks, which resulted in the ls of /dev/disk/by-id would return an empty string and the lack of quoting around this condition would cause the script to fail.
I'm not sure if this is an artifact of how I was testing or if there is actually something else that was missing, either way this is a safe way to ensure that info directory exists for the following code that fetches instance metadata.
I'm planning to add another condition to this logic and the conditions are already getting complex, so instead lets introduce a flag for when the system should reboot and set it accordingly
Since these instance types were only released around the time that Buster was already out, the default kernel 'works' but has some limitations. For Buster arm64 we want to switch to linux-image-cloud-arm64 which runs 5.7 instead of 4.19 to get better support. In future releases, the differences between the cloud and default images are negligible.
jbergler
force-pushed
the
arm64-builders
branch
from
f197c4e
to
c53fa6b
Compare
No worries, I pushed some more changes from testing the bootstrap scripts manually. |
|
Hey @behlendorf, no rush, just checking in here to see if you've had a chance to look at this at all / if there was anything else I can do? |
|
@jbergler the change looks reasonable but I haven't yet had a chance to give it a test. Hopefully in the next couple of days, sorry about the delay. |
|
Merged! This change worked out nicely with just a few minor tweaks. Thanks for putting this together, I've gone ahead and rolled out the new Debian 10 arm64 builder. |
I've noticed that there has been a small handful of issues with GPL
violations on arm64 over the past year or so. It seems like this is
something we can catch by leveraging the AWS graviton arm64 instances
for build slaves.