This repository has been archived by the owner on Oct 29, 2024. It is now read-only.
Don't fail to install dependencies if kernel headers fail on Debian #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As [the buildbot shows](http://build.zfsonlinux.org/builders/Debian%2010%20arm64%20%28BUILD%29) right now, if the big monolithic apt-get command has a package missing (say, linux-headers-4.19.0-11-arm64), it will fail to install any of them. Since breaking it into a bunch of install commands would increase the runtime substantially, just break out the headers install to a separate command, have it fall back to trying to install the latest headers for the arch anyway, and then install the other dependencies separately, so hopefully the erroring next time requires less digging to figure out the kernel headers were missing, not zlib1g-dev.
|
Sorry I missed this. The Debian repositories sorted out whatever their issue was but this still seems like a good idea. I'll see about getting it pulled in. |
|
Closing. We've retired the buildbot and migrated to GitHub actions for the CI. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the buildbot shows right now, if the big monolithic apt-get command has a package missing (say, linux-headers-4.19.0-11-arm64), it will fail to install any of them.
Since breaking it into a bunch of install commands would increase the runtime substantially, just break out the headers install to a separate command, have it fall back to trying to install the latest headers for the arch anyway, and then install the other dependencies separately, so hopefully the erroring next time requires less digging to figure out the kernel headers were missing, not zlib1g-dev.
(Technically it having any headers could make it succeed and fail to load modules later, but since I suspect what's happening is the initial VM bringup is slightly too old so its headers are no longer in the repo, either we try with the latest headers assuming we're going to be using that kernel version, or we fail until someone updates the base VM.
If we want to be sure we boot the latest kernel, of course, we could explicitly install that...)