Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD: Enable Direct IO by default #16761

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Enable Direct IO for FreeBSD.

Description

Commits 25eb538, 1786825, and 8dc452d resolve the remaining known issues with Direct IO on FreeBSD. Enable it by default on all platforms.

How Has This Been Tested?

Locally tested in the PRs which resolved the above remaining issues. Additional tests to be done by the CI.

@markjdb thanks for sorting out these issues. Unless you know of any other problems let's enable this by default.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Commits 25eb538, 1786825, and 8dc452d resolve the remaining
known issues with Direct IO on FreeBSD. Enable it by default on all
platforms.

Signed-off-by: Brian Behlendorf <[email protected]>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Nov 15, 2024
@markjdb
Copy link
Contributor

markjdb commented Nov 15, 2024

@markjdb thanks for sorting out these issues. Unless you know of any other problems let's enable this by default.

I believe @bwatkinson is still characterizing a problem with O_DIRECT reads - there is some discussion going on in an email thread, so we should hold off until that's resolved.

@behlendorf behlendorf marked this pull request as draft November 15, 2024 18:35
@github-actions github-actions bot added Status: Work in Progress Not yet ready for general review and removed Status: Code Review Needed Ready for review and testing labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Work in Progress Not yet ready for general review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants