userprops: make clearing pool & vdev userprops work the same #16887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robn
force-pushed
the
clear-pool-vdev-userprops
branch
from
9d98a92 to
17421a6
Compare
VDEV_PROP_USERPROP is equal do VDEV_PROP_INVAL and so is not a real property. That's why vdev_prop_readonly() does not work right for it. In particular it may declare all vdev user properties readonly on FreeBSD. Signed-off-by: Alexander Motin <[email protected]> Sponsored by: iXsystems, Inc.
If a vdev userprop is not found, present it as value '-', default source, so it matches the output from pool userprops. Sponsored-by: Klara, Inc. Sponsored-by: Wasabi Technology, Inc. Signed-off-by: Rob Norris <[email protected]>
People have noted there's no way to remove a pool userprop, only zero it. Turns vdev userprops had a method, by setting empty-string. So this makes pool userprops follow the same behaviour. Sponsored-by: Klara, Inc. Sponsored-by: Wasabi Technology, Inc. Signed-off-by: Rob Norris <[email protected]>
Confirming that clearing pool and vdev userprops produce the same result: an empty value, with default source. Sponsored-by: Klara, Inc. Sponsored-by: Wasabi Technology, Inc. Signed-off-by: Rob Norris <[email protected]>
robn
force-pushed
the
clear-pool-vdev-userprops
branch
from
17421a6 to
d67914e
Compare
13 tasks
|
Seems to be happy now. The FreeBSD 15 failures seem unrelated and should be fixed by #16892 . |
behlendorf
approved these changes
Dec 20, 2024
behlendorf
added
Status: Accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Sponsors: Klara, Inc., Wasabi Technology, Inc.]
Motivation and Context
Someone told me recently that it wasn't possible to clear pool userprops once set. I looked at it today.
I found that setting them to the empty-string actually does set them, that is, their source stays "local". vdev props on the other hand, really do delete the property (remove from the ZAP).
On the other side, if you request a userprop that doesn't exist, pool userprops will show an empty, default-source value, which vdev props simply won't be displayed.
Description
This makes empty/clearing pool and vdev userprops behave the same way:
How Has This Been Tested?
Test added to make sure these work and do the same thing.
Types of changes
Checklist:
Signed-off-by.