Allow symlinks to non-existing-directories to work

As a directory, with XATTR for reparse-point would have zsize > 2, we need to use the zap count instead. Signed-off-by: Jorgen Lundman <[email protected]>
openzfsonwindows · Sep 13, 2024 · 2a63b77 · 2a63b77
1 parent 434733f
commit 2a63b77
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/module/os/windows/spl/spl-vnode.c b/module/os/windows/spl/spl-vnode.c
@@ -938,7 +938,7 @@ vnode_ischr(vnode_t *vp)
 int
 vnode_isswap(vnode_t *vp)
 {
-	return (0);
+	return (vp->v_type == VFIFO);
 }
 
 int
@@ -950,7 +950,7 @@ vnode_isfifo(vnode_t *vp)
 int
 vnode_islnk(vnode_t *vp)
 {
-	return (0);
+	return (vp->v_type == VLNK);
 }
 
 mount_t *

diff --git a/module/os/windows/zfs/zfs_vnops_windows_lib.c b/module/os/windows/zfs/zfs_vnops_windows_lib.c
@@ -3227,7 +3227,7 @@ zfs_setunlink(FILE_OBJECT *fo, vnode_t *dvp)
 	// are not empty.
 	if (S_ISDIR(zp->z_mode)) {
 
-		if (zp->z_size > 2) {
+		if (!zfs_dirempty(zp)) {
 			Status = STATUS_DIRECTORY_NOT_EMPTY;
 			goto out_unlock;
 		}