-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce MediaWiki Parsoid API to render articles #1899
base: main
Are you sure you want to change the base?
Conversation
@VadimKovalenkoSNF I'm a bit lost, can you please tell:
Any chance to get that completed today? |
@kelson42 , I haven't noticed dedicated ticket for mwoffliner. This patch mostly replicates functionality from #1846 but on top of recent changes. In fact, it solves both problems - reduces traffic to MW infrastructure + allows mwoffliner to avoid redundant request to get modules per article if Wiki supports action API with |
No real need to open an issue our side... glad if i can review tge PR soon. |
Update: I've noticed that parsoid API has troubles with media treatment, and probably other issues in the output. |
@VadimKovalenkoSNF can you please explain in description the principle of your PR because i don't get it. It shoukd be onkt about adding "parsoid" to an url... and now we talk about something very different. |
@kelson42 This PR introduces new renderer based on As you can see, it has The problem I denoted is about different article html from MediaWiki Action API and WikimediaDesktop response which in result will lead to the different output (missing media, etc) |
@VadimKovalenkoSNF Needs to be rebased |
Fixes https://phabricator.wikimedia.org/T324866
Superseeds #1846