Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle images that do not have data-width or data-height #2114

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

audiodude
Copy link
Member

Fixes #2113

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 75.24%. Comparing base (1763a23) to head (5b00f29).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/renderers/wikimedia-mobile.renderer.ts 66.66% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2114      +/-   ##
==========================================
- Coverage   75.43%   75.24%   -0.20%     
==========================================
  Files          41       41              
  Lines        3188     3195       +7     
  Branches      703      706       +3     
==========================================
- Hits         2405     2404       -1     
- Misses        666      674       +8     
  Partials      117      117              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@audiodude audiodude merged commit 613b81f into main Dec 10, 2024
5 of 6 checks passed
@audiodude audiodude deleted the fix-2113 branch December 10, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to scrape ca.wikipedia.org with 1.14.0
1 participant