-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logs for API checks #2125
Add logs for API checks #2125
Conversation
See #2090 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2125 +/- ##
==========================================
+ Coverage 75.25% 75.33% +0.07%
==========================================
Files 41 41
Lines 3197 3207 +10
Branches 706 706
==========================================
+ Hits 2406 2416 +10
Misses 674 674
Partials 117 117 ☔ View full report in Codecov by Sentry. |
I love this. Given these checks are done only once per scrape, the 4 additional log lines are "very cheap" and having the exact URL used helps a lot to ensure there is no problem of misconfiguration of the scraper URLs. My only suggestion is that you should probably use |
2aa53fe
to
191e6fb
Compare
Thanks, done. |
@audiodude Could we use also this PR to log as well what API end-point(s) is/are chosen at the end? |
191e6fb
to
67d6801
Compare
Great idea, done. |
67d6801
to
3043442
Compare
Also changed the code to only build the URL once, PTAL |
@audiodude I guess this is ready to review!? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please consider replacing Checking
with Checked
in the messages since the check is complete once log is done
This will help debugging when we get a message along the lines of "No available [foo] renderer".